Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set pointBackgroundColor in radar sample #6013

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jan 24, 2019

Closes #5176

@benmccann
Copy link
Contributor

benmccann commented Jan 24, 2019

I tried editing this line locally. It doesn't seem like it's doing anything or maybe I'm just missing something. But whether I call it pointBorderColor or pointBackgroundColor or remove it, the chart looks exactly the same to me in all cases

I'd rather just remove this line if it doesn't do anything

@kurkle
Copy link
Member Author

kurkle commented Jan 25, 2019

@benmccann notice it's in the addDataset button code.

@simonbrunel simonbrunel merged commit e6a0c86 into chartjs:master Jan 25, 2019
@benmccann
Copy link
Contributor

Yes, I tested pressing the add dataset button. It still does nothing as far as I can tell

@kurkle
Copy link
Member Author

kurkle commented Jan 25, 2019

Yes, I tested pressing the add dataset button. It still does nothing as far as I can tell

Made a pen to demonstrate (with larger pointRadius to make it more obvious)
https://codepen.io/kurkle/pen/daGpRe

@benmccann
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants